[U-Boot] [PATCH 1/4]: arm: Kirkwood: Set MAC address during registration for kirkwood egiga

[Prafulla Wadaskar]

> -----Original Message-----
> From: u-boot-bounces at lists.denx.de 
> [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Simon Kagstrom
> Sent: Friday, July 10, 2009 12:55 PM
> To: Ben Warren
> Cc: U-Boot ML
> Subject: Re: [U-Boot] [PATCH 1/4]: arm: Kirkwood: Set MAC 
> address during registration for kirkwood egiga
> 
> On Thu, 09 Jul 2009 22:44:10 -0700
> Ben Warren <biggerbadderben at gmail.com> wrote:
> 
> > Simon Kagstrom wrote:
> > > This patch sets the MAC address during registration in 
> addition to 
> > > during device init. Since U-boot might not access the ethernet 
> > > device, Linux might end up with the MAC address unset.
> > >   
> > I think this violates U-boot policy of only touching 
> hardware if it's 
> > used, but Wolfgang can say for sure.  In general, initialize() 
> > functions should just set up data structures and register 
> the device.  
> > There's a long history of MAC-address issues with ARM chips 
> and Linux 
> > that I've happily stayed clear of so can't claim to be an 
> expert here.
> 
> OK, I've tried looking around at how other boards do it, and 
> at least the most similar (mv6436x_eth_initialize() for other
This is a wrong reference, even this was my initial reference, but there are no updates to this code, we were planning to clean it but we do not have hardware to test it.
Does any one have it?
 
> Marvell boards) do it the same way as well as some others (ax88180.c).
If posible can be improved.

> 
> Should Linux otherwise read the passed U-boot environment and 
> set it up by itself?
I think this is better approach,
Regards..
Prafulla . .

> 
> // Simon
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>