[U-Boot] [PATCH 1/4]: arm: Kirkwood: Set MAC address during registration for kirkwood egiga

Wolfgang Denk wd at denx.de
Sat Jul 11 11:25:29 CEST 2009


Dear Ben Warren,

In message <4A56D52A.8010401 at gmail.com> you wrote:
> Simon Kagstrom wrote:
> > This patch sets the MAC address during registration in addition to
> > during device init. Since U-boot might not access the ethernet device,
> > Linux might end up with the MAC address unset.
> >   
> I think this violates U-boot policy of only touching hardware if it's 
> used, but Wolfgang can say for sure.  In general, initialize() functions 
> should just set up data structures and register the device.  There's a 
> long history of MAC-address issues with ARM chips and Linux that I've 
> happily stayed clear of so can't claim to be an expert here.

You are correct. Devices shall only be initialized when actually used
in U-Boot (upon first use).

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There is an order of things in this universe.
	-- Apollo, "Who Mourns for Adonais?" stardate 3468.1


More information about the U-Boot mailing list