[U-Boot] [PATCH 1/2][repost] usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root

Remy Bohmer linux at bohmer.net
Sat Jul 11 11:39:49 CEST 2009


Hello Michael,

2009/7/10 Michael Trimarchi <trimarchi at gandalf.sssup.it>:
> Hi,
>
> cc: Remy Bohmer
>
> Prafulla Wadaskar wrote:
>>
>> This patch is tested for USB host interface on Kirkwood based
>> Sheevaplug platform (i.e arm little-endian machine)
>>
>> Signed-off-by: Prafulla Wadaskar <prafulla at marvell.com>
>> ---
>>  drivers/usb/host/ehci-hcd.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
>> index bbd547b..7a55638 100644
>> --- a/drivers/usb/host/ehci-hcd.c
>> +++ b/drivers/usb/host/ehci-hcd.c
>> @@ -550,7 +550,7 @@ ehci_submit_root(struct usb_device *dev, unsigned long
>> pipe, void *buffer,
>>              req->requesttype, req->requesttype,
>>              le16_to_cpu(req->value), le16_to_cpu(req->index));
>>  -       typeReq = req->request << 8 | req->requesttype;
>> +       typeReq = req->request | req->requesttype << 8;
>>          switch (le16_to_cpu(typeReq)) {

To be sure about the difference of opinions here about the le16_to_cpu() macro.
Do you agree with this patch? If so, I will apply it.

Kind Regards,

Remy


More information about the U-Boot mailing list