[U-Boot] [PATCH] ubi: help message correction
Wolfgang Denk
wd at denx.de
Sun Jul 12 08:30:07 CEST 2009
Dear Andrzej Wolski,
In message <h3bhhv$l6g$1 at ger.gmane.org> you wrote:
> Fix incorrect information about size units.
>
> Signed-off-by: Andrzej Wolski <awolski at poczta.fm>
> ---
> diff --git a/common/cmd_ubi.c b/common/cmd_ubi.c
> index bbca389..d1653b1 100644
> --- a/common/cmd_ubi.c
> +++ b/common/cmd_ubi.c
> @@ -608,6 +608,6 @@ U_BOOT_CMD(ubi, 6, 1, do_ubi,
> " - Remove volume\n"
> "[Legends]\n"
> " volume: charater name\n"
> - " size: KiB, MiB, GiB, and bytes\n"
> + " size: hex value\n"
> " type: s[tatic] or d[ynamic] (default=dynamic)"
> );
This is IMHO not a helpful help message.
First, it is reduncant, as all input in U-Boot is in hex format. So
why repeat that information. And "size: value" - what does that tell
me? Would it not be good to mention the unit? Is it in KiB, MiB, GiB,
bytes, blocks, or whatever?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"We don't have to protect the environment -- the Second Coming is at
hand." - James Watt
More information about the U-Boot
mailing list