[U-Boot] [PATCH 1/2 v6] Make libgcc inclusion from common Makefile overridable by platform config file

[Wolfgang Denk]

Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <20090712195107.GC1686 at game.jcrosoft.org> you wrote:
>
> > > > On  ARM  the  use  of  libgcc should be the default like on all other
> > > > architectures - only if needed it should be possible to switch  on  a
> > > > don't-use-libgcc  mode,  but  this  should  then  be  independent  of
> > > > architecture, either.
> > > which is the case no arch are force to switch the current patch just allow
> > > to switch to this mode.
> > 
> > My understanding was that the current patch (1) makes not using
> > lingcc the default for ARM, and (2) makes it the default for ARM for
> > all too chains.
> the current patch do 2 thinks
> PATCH 1 allow to switch or not (by default use the toolchains libgcc)

The switch will be based on a configuration setting, i.  e.  you  can
change  it  only  by changing the source code. You cannot for example
compile the very same source code  (without  any  changes  to  U-Boot
source  files) one time with and one time without using libgcc.

> PATCH 2 for ARM only switch and do not use the libgcc anymore

So it makes it not only the default, but actually the only  supported
setting (assuming you do not change the source code).

Thanks for explaining the implementation to me.

> > > unfortunately most of the arm toolchains are not sane for every point of view
> > > as you can not build U-Boot, kernel and userland with the same optimized
> > > toolchain most of the time.
> > 
> > But ARM is just one out of many different  architectures,  and  there
> > are  eventually  (sufficently)  sane  ARM tool chains available, too.
> > This is the default case, and shall remain it.
> > 
> > For broken tool chains (ARM or other) the feature can be activated
> > (when running make).
> Currently on arm you have more unsane toolchains than sane

Maybe. This does not change any of my arguments.


I have made up my mind. I hereby reject patches 1 and 2 in their
current form.

To have the patches accepted for imainline, use of libgcc  should  be
the  common  default  setting for all architectures, and switching of
the use of libgcc should be possible for any board and any  architec-
ture without having to change any file in the U-Boot source tree.

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
No question is too silly to ask. Of course, some  questions  are  too
silly to to answer...  - L. Wall & R. L. Schwartz, _Programming Perl_