[U-Boot] [PATCH][repost] bin_dep.sh Support

[Prafulla Wadaskar]

> -----Original Message-----
> From: Wolfgang Denk [mailto:wd at denx.de] 
> Sent: Monday, July 13, 2009 4:56 PM
> To: Prafulla Wadaskar
> Cc: u-boot at lists.denx.de; Manas Saksena; Ronen Shitrit; 
> Nicolas Pitre; Ashish Karkare; Prabhanjan Sarnaik; Lennert Buijtenhek
> Subject: Re: [U-Boot] [PATCH][repost] bin_dep.sh Support
> 
> Dear Prafulla Wadaskar,
> 
> In message 
> <1247498802-12488-1-git-send-email-prafulla at marvell.com> you wrote:
> > From: prafulla_wadaskar <prafulla at marvell.com>
> > 
> > In some cases the u-boot.bin need to be processed further to create 
> > bootable u-boot binary from boot device This processing may 
> be cpu,soc 
> > and/or board spcific bin_dep.sh provides a mechanism to execute 
> > bin_dep.sh if present in above platform specific folders
> > 
> > Signed-off-by: prafulla_wadaskar <prafulla at marvell.com>
> > ---
> >  Makefile         |    2 +
> >  tools/bin_dep.sh |   79 
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 81 insertions(+), 0 deletions(-)  create 
> mode 100755 
> > tools/bin_dep.sh
> > 
> > diff --git a/Makefile b/Makefile
> > index f857641..8bf36ce 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -318,6 +318,7 @@ $(obj)u-boot.srec:	$(obj)u-boot
> >  
> >  $(obj)u-boot.bin:	$(obj)u-boot
> >  		$(OBJCOPY) ${OBJCFLAGS} -O binary $< $@
> > +		@./tools/bin_dep.sh $(CPU) $(BOARD) $(VENDOR) $(SOC) $@
> 
> NAK. I reject this patch, and I will continue to reject all 
> attempts to perform additional operations on the u-boot.bin image.
> 
> u-boot.bin is by definition the raw binary image of  U-Boot.  
> If  you use  additional  tools  to  post-process  this  
> image,  then  you are creating a new image format, which must 
> have it's own name.g

Then I feel what Jean has suggested is the only way to go ahead with kirkwood use case
I will go ahead with this.

Ref:
> > we can simply add a new target
> > u-boot.kwd
> > which will do somthing like this
> > 
> > $(obj)u-boot.kwd:	$(obj)u-boot.bin
> > 	$(do_image) $(obj)u-boot.kwd $(obj)u-boot.bin 
> > $(obj)board/$(BOARDDIR)/sdramregs.txt


Second issue:
I will have to add a tool i.e. do_image (to be renamed) which will create u-boot.kwd.
this tool is specific to Kirkwood only,
I am going to add this in ./tools/ folder (as per Jean's feedback earlier), is this okay?

Regards..
Prafulla . .