[U-Boot] DHCP regression on 2009-06

Robin Getz rgetz at blackfin.uclinux.org
Mon Jul 13 17:58:16 CEST 2009


On Mon 13 Jul 2009 11:11, Michael Zaidman pondered:
> > I did verify that reverting the line exposes the bug that Michael fixed, ...
> 
> Ok, my target uses static IP configuration so I did not verified the DHCP
> behavior. Now I did it. I also reverted the line and did DHCP afterwards
> changed the subnet and did DHCP again. It works as expected.
> 
> diff --git a/net/net.c b/net/net.c
> index 5637cf5..5e43dd1 100644
> --- a/net/net.c
> +++ b/net/net.c
> @@ -388,6 +388,7 @@ restart:
>  #if defined(CONFIG_CMD_DHCP)
>                 case DHCP:
>                         BootpTry = 0;
> +                       NetOurIP = 0;
>                         DhcpRequest();          /* Basically same as BOOTP */
>                         break;
>  #endif
> 

But -- doesn't this expose the ping issue you were trying to fix?



More information about the U-Boot mailing list