[U-Boot] DHCP regression on 2009-06

[Ben Warren]

On Tue, Jul 14, 2009 at 2:26 AM, Michael Zaidman
<michael.zaidman at gmail.com>wrote:

> On Mon, Jul 13, 2009 at 9:40 PM, Robin Getz <rgetz at blackfin.uclinux.org>
> wrote:
> >
> > On Mon 13 Jul 2009 11:11, Michael Zaidman pondered:
> > > > I did verify that reverting the line exposes the bug that Michael
> fixed, ...
> > >
> > > Ok, my target uses static IP configuration so I did not verified the
> DHCP
> > > behavior. Now I did it. I also reverted the line and did DHCP
> afterwards
> > > changed the subnet and did DHCP again. It works as expected.
> > >
> > > diff --git a/net/net.c b/net/net.c
> > > index 5637cf5..5e43dd1 100644
> > > --- a/net/net.c
> > > +++ b/net/net.c
> > > @@ -388,6 +388,7 @@ restart:
> > >  #if defined(CONFIG_CMD_DHCP)
> > >                 case DHCP:
> > >                         BootpTry = 0;
> > > +                       NetOurIP = 0;
> > >                         DhcpRequest();          /* Basically same as
> BOOTP */
> > >                         break;
> > >  #endif
> > >
> >
> > OK - I tested it - and it seems to work for me.
> >
> > Some of my debugging crap when I was tracking this down must have messed
> this up.
> >
> > Ack-by: Robin Getz <rgetz at blackfin.uclinux.org>
>
> If nobody has objections I can submit this fix.
>
> Michael.
>

Please do.

regards,
Ben