[U-Boot] [PATCH 1/3] factor out common code for matrix vision boards

Wolfgang Denk wd at denx.de
Thu Jul 16 22:54:32 CEST 2009


Dear =?ISO-8859-1?Q?Andr=E9?= Schwarz,

In message <1245678391.3867.11.camel at swa-m460> you wrote:
> 
> factor out common code for Matrix Vision based boards.
> 
> Signed-off-by: Andre Schwarz <andre.schwarz at matrix-vision.de>
> ---
>  board/matrix_vision/common/Makefile    |   54 ++++++++++++++
>  board/matrix_vision/common/mv_common.c |  125 ++++++++++++++++++++++++++++++++
>  board/matrix_vision/common/mv_common.h |   25 +++++++
>  3 files changed, 204 insertions(+), 0 deletions(-)
>  create mode 100644 board/matrix_vision/common/Makefile
>  create mode 100644 board/matrix_vision/common/mv_common.c
>  create mode 100644 board/matrix_vision/common/mv_common.h

Hm... to me factor out means removing the same part of code form
several places and adding a unique copy of it somewhere. But I see
only added code, none removed?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"In matters of principle, stand like a rock;  in  matters  of  taste,
swim with the current."                            - Thomas Jefferson


More information about the U-Boot mailing list