[U-Boot] [PATCH 2/6] S5PC100: SMDKC100 Board support

Minkyu Kang promsoft at gmail.com
Fri Jul 17 10:42:41 CEST 2009


2009/7/11 Wolfgang Denk <wd at denx.de>:
> Dear HeungJun Kim,
>
> In message <350d1ec30906250108q5949e337neb54520d6773f94f at mail.gmail.com> you wrote:
>> This patch initializes DRAM memory, OneNAND, & Board specific functions.
>> Also, it includes SMDKC100 configuration file & modification of Makefile.
>>
>> Signed-off-by: HeungJun, Kim <riverful.kim at samsung.com>
>>
>> ---
>>
>>  Makefile                               |    5 +
>>  board/samsung/smdkc100/Makefile        |   54 +++++++
>>  board/samsung/smdkc100/config.mk       |   24 +++
>>  board/samsung/smdkc100/lowlevel_init.S |  215 ++++++++++++++++++++++++++++
>>  board/samsung/smdkc100/mem_setup.S     |  197 ++++++++++++++++++++++++++
>>  board/samsung/smdkc100/onenand.c       |   78 ++++++++++
>>  board/samsung/smdkc100/smdkc100.c      |   70 +++++++++
>>  board/samsung/smdkc100/u-boot.lds      |   63 ++++++++
>>  include/configs/s5pc100_smdkc100.h     |  244 ++++++++++++++++++++++++++++++++
>>  9 files changed, 950 insertions(+), 0 deletions(-)
>>  create mode 100644 board/samsung/smdkc100/Makefile
>>  create mode 100644 board/samsung/smdkc100/config.mk
>>  create mode 100644 board/samsung/smdkc100/lowlevel_init.S
>>  create mode 100644 board/samsung/smdkc100/mem_setup.S
>>  create mode 100644 board/samsung/smdkc100/onenand.c
>>  create mode 100644 board/samsung/smdkc100/smdkc100.c
>>  create mode 100644 board/samsung/smdkc100/u-boot.lds
>>  create mode 100644 include/configs/s5pc100_smdkc100.h
>
> MAINTAINERS entry missing.
>
>> diff --git a/board/samsung/smdkc100/onenand.c b/board/samsung/smdkc100/onenand.c
>> new file mode 100644
>> index 0000000..70105a6
>> --- /dev/null
>> +++ b/board/samsung/smdkc100/onenand.c
> ...
>> +#define DPRINTK(format, args...)                                     \
>> +do {                                                                 \
>> +     printk("%s[%d]: " format "\n", __func__, __LINE__, ##args);     \
>> +} while (0)
>
> Macro unused in this file, so please do not add dead code. Also,
> rather use debug().
>
>
>> +int dram_init(void)
>> +{
>> +     DECLARE_GLOBAL_DATA_PTR;
>> +
>> +     gd->bd->bi_dram[0].start = PHYS_SDRAM_1;
>> +     gd->bd->bi_dram[0].size = PHYS_SDRAM_1_SIZE;
>> +
>> +     return 0;
>> +}
>
> Why not using get_ram_size() for auto-detection and testing?
>
>> +void raise(void)
>> +{
>> +}
>
> Why would that be needed?
>

Actually this function is workaround.
because of undefined reference error

/opt/toolchains/arm-2008q3/bin/../lib/gcc/arm-none-linux-gnueabi/4.3.2/libgcc.a(_dvmd_lnx.o):
In function `__aeabi_ldiv0':
(.text+0x8): undefined reference to `raise'

I want to solve it but can't find the reason yet.
How i can fix this problem?

thanks

-- 
from. prom.
www.promsoft.net


More information about the U-Boot mailing list