[U-Boot] [PATCH] Add "cpu_config" command for PPC4xx bootstrap configuration

[Stefan Roese]

On Friday 17 July 2009 13:20:17 Wolfgang Denk wrote:
> > > Would it be possible to also mark the current setting in this output?
> > > Like printing an asterisk befor or after it?
> >
> > No. Currently the implementation only checks strings and has no idea of
> > frequencies. Also, not only PLL frequencies are configured in this I2C
> > bootstrap EEPROM but also boot-location (NOR, NAND, PCI) and other
> > things. So it's really not trivial to find/search the current
> > configuration in this table.
>
> Umm.. I think it should be fairly trivial to read the current  EEPROM
> settings and compare these against the entries in the table above?

OK, this could be done. Even if I don't see a real advantage here. But I'll 
add it anyway in the next patch version.

> > Since 4xx prints the speed's in the bootlog, it shouldn't be too hard to
> > find the current setting there (if necessary).
>
> But would it not be  useful  to  be  able  to  detect  any  "illegal"
> settings,  for  example resulting from accidentyial corruption of the
> EEPROM data?

I don't understand this. How should the code detect an "illegal" setting? All 
settings configured in the board specific code are valid.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================