[U-Boot] PATCH

Wolfgang Denk wd at denx.de
Fri Jul 17 15:21:57 CEST 2009


Dear =?ISO-8859-1?Q?Andr=E9?= Schwarz,

In message <1247834498.3953.34.camel at swa-m460> you wrote:
> This patch adds common code usable for all Matrix Vision boards.
> 
> Signed-off-by: Andr=C3=A9 Schwarz <andre.schwarz at matrix-vision.de>
> ---
> 
>  board/matrix_vision/common/Makefile    |   54 ++++++++++++++
>  board/matrix_vision/common/mv_common.c |  125
> ++++++++++++++++++++++++++++++++
>  board/matrix_vision/common/mv_common.h |   25 +++++++
>  3 files changed, 204 insertions(+), 0 deletions(-)

No. Please see my previous review comments.

The patches that add common code and that remove this common code from
the multiple places where it was before should be merged into one
atomic change.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Far back in the mists of ancient time, in the great and glorious days
of the former Galactic Empire, life was wild, rich  and  largely  tax
free.         - Douglas Adams, _The Hitchhiker's Guide to the Galaxy_


More information about the U-Boot mailing list