[U-Boot] [PATCH 1/2] update config for mvBL-M7 (MPC8343)

[Heiko Schocher]

Hello André,

André Schwarz wrote:
> Heiko,
> 
> this patch is no longer valid since I already posted v2.

Ah, ok.

> But your comments are correct ...
> 
> Will wait for WD's comments and send v3.

OK, one more minor comment ...

> On Fri, 2009-07-17 at 16:15 +0200, Heiko Schocher wrote:
>> Hello André,
>>
>> André Schwarz wrote:
>>> This patch fixes DDR-II settings and adds I2C support.
>>>
>>>
>>> Signed-off-by: André Schwarz <andre.schwarz at matrix-vision.de>
>>> ---
>>>
>>>  include/configs/MVBLM7.h |   48
>>> ++++++++++++++++++++-------------------------
>>>  1 files changed, 21 insertions(+), 27 deletions(-)
>>>
>>> diff --git a/include/configs/MVBLM7.h b/include/configs/MVBLM7.h
>>> index ac8cb57..6e347e8 100644
>>> --- a/include/configs/MVBLM7.h
>>> +++ b/include/configs/MVBLM7.h
>>> @@ -47,12 +47,14 @@
>>>  #define CONFIG_MPC8XXX_SPI
>>>  #define CONFIG_HARD_SPI
>>>  #define MVBLM7_MMC_CS   0x04000000
>>> +#define CONFIG_MISC_INIT_R
>> So misc_init_r () gets called, but I didn;t find this in your
>> patch? May I miss something ...
> 
> It's included in the other "common code" patch.

Hmm... but this will break git-bisect compatibility, and if we
have such a tool for searching bugs, we should make patches which
are "git bisect compatible" ... so please look, that patches compile
clean ...

bye
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany