[U-Boot] [PATCH] cmd_mmc: make curr_device static
Wolfgang Denk
wd at denx.de
Fri Jul 17 22:16:15 CEST 2009
Dear Mike Frysinger,
In message <200907151109.06151.vapier at gentoo.org> you wrote:
> --nextPart4747607.DNTvaE3gLs
> Content-Type: text/plain;
> charset="iso-8859-1"
> Content-Transfer-Encoding: quoted-printable
> Content-Disposition: inline
>
> On Sunday 14 June 2009 21:35:21 Mike Frysinger wrote:
> > The curr_device variable isn't used outside of cmd_mmc, so mark it static
> > to avoid conflicts with other pieces of code (like sata which also exports
> > a curr_device). Otherwise we end up with stuff like:
> > common/libcommon.a(cmd_sata.o):(.data.curr_device+0x0):
> > multiple definition of `curr_device'
> > common/libcommon.a(cmd_mmc.o):(.data.curr_device+0x0): first defined here
>
> Wolfgang: were you waiting on some thing/one with this and the similar sata
> cmd change ? or was it lost in the shuffle ?
It was not lost. I was waiting for a few hours to work on patches...
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
When all is said and done, more is said than done.
More information about the U-Boot
mailing list