[U-Boot] [PATCH 1/2] new video driver for bus vcxk framebuffers

Jens Scharsig esw at bus-elektronik.de
Mon Jul 20 08:45:06 CEST 2009


Hello Anatolij,

>> +initialize the reset line to vcxk hardware and release it from reset
> 
> Looking on the changes to board configuration file
> "include/configs/EB+MCF-EV123.h" in the second patch of this series
> I now realize that most of these CONFIG_SYS_ macros above expand to
> C code, so these are not configuration options any more.
> I tend to reject all this. CONFIG_SYS_ options are supposed to be options
> and not board specific code. VCxK.c driver you removed by this patch
> series did it in more correct way, I think.
> What about moving this code to functions which use board specific macros?
> These functions should be placed in this new video driver then.
> 

I will complete review the code.
I think, i can sent a new patch set within one week

Best regards,

Jens Scharsig


More information about the U-Boot mailing list