[U-Boot] [PATCH] ppc4xx: Fixed compilation warning in 4xx_enet.c
Stefan Roese
sr at denx.de
Mon Jul 20 10:40:55 CEST 2009
Hi Ben,
On Saturday 11 July 2009 20:56:06 Alessio Centazzo wrote:
> This patch fixes a compilation warning for some Ethernet PHY-less
> PPC4xx platforms (440SPE based ones) and a potential compilation
> error for 440SP platforms (use of undefined 'ethgroup' variable).
> In the original code and in case of 440SPE platforms, 'ethgroup'
> is initialized to -1 and never modified. Later in the function,
> within an #ifdef statement, an 'if statement' executes code only
> if 'ethgroup' is set to 4, therefore it is harmless to avoid
> executing the 'if statement' by removing the CONFIG_440SPE from
> the affected #ifdefs. In case of 440SP platforms with on-board
> Ethernet PHY, 'ethgroup' is undefined but used (there are not such
> platforms in the repository yet). All other architectures are not
> affected by this change.
>
> Signed-off-by: Alessio Centazzo acpatin at yahoo.com
This patch falls into your responsibility now. I have no objections, so:
Acked-by: Stefan Roese <sr at denx.de>
Thanks.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
More information about the U-Boot
mailing list