[U-Boot] [PATCH] OneNAND: Runtime badblock support

[Wolfgang Denk]

Dear Kyungmin Park,

In message <20090721095528.GA23408 at july> you wrote:
> At bootloader, we don't need to read full page. It takes too long time.
> Instead it only read pages required for boot.
> Of course, this patch reduces the boot time

What does "don't need to read full page" mean? 
when we read pages, we always read fullpages, don't we?

> @@ -155,6 +192,11 @@ static int onenand_isbad_bbt(struct mtd_info *mtd, loff_t offs, int allowbbt)
>  	block = (int)(offs >> (bbm->bbt_erase_shift - 1));
>  	res = (bbm->bbt[block >> 3] >> (block & 0x06)) & 0x03;
>  
> +	if (this->options & ONENAND_RUNTIME_BADBLOCK_CHECK) {
> +		if (res == 0x02)
> +			res = read_page_oob(mtd, offs, this->oob_buf);
> +	}
> +

ONENAND_RUNTIME_BADBLOCK_CHECK is a new #define, right? It should be
documented (for example in the README, or even better in
doc/README.OneNand or so).

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Quote from the Boss after overriding the decision of a task force  he
created  to  find  a  solution:  "I'm  sorry  if  I ever gave you the
impression your input would have any effect on my  decision  for  the
outcome of this project!"