[U-Boot] [PATCH][FIXED] zlib: updated to v.1.2.3

Wolfgang Denk wd at denx.de
Wed Jul 22 09:20:14 CEST 2009


Dear Giuseppe CONDORELLI,

In message <1248168763-10042-1-git-send-email-giuseppe.condorelli at st.com> you wrote:
> This patch updates zlib to the latest stable version.
> Only relevant zlib parts were ported to u-boot tree, as already did for the
> current zlib (0.95). New zlib guarantees a faster inflate performances
> other then others improvements as explained at www.zlib.net
> 
> Signed-off-by: Giuseppe Condorelli <giuseppe.condorelli at st.com>
> ---
>  include/u-boot/zlib.h |  718 ++++++---
>  lib_generic/zlib.c    | 3930 +++++++++++++++++++++++++------------------------
>  2 files changed, 2463 insertions(+), 2185 deletions(-)

D*MN!!!

Don't you test your code at all?!?!?

Configuring for cmi_mpc5xx board...
gunzip.c: In function 'zunzip':
gunzip.c:101: warning: assignment from incompatible pointer type
In file included from zlib.c:29:
/home/wd/git/u-boot/work/include/u-boot/zlib.h:667: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'crc32'
zlib.c: In function 'inflate':
zlib.c:1388: warning: implicit declaration of function 'crc32'
make[1]: *** [/work/wd/tmp-ppc/lib_generic/zlib.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [/work/wd/tmp-ppc/lib_generic/libgeneric.a] Error 2
make: *** Waiting for unfinished jobs....
ppc_6xx-size: '/work/wd/tmp-ppc/u-boot': No such file
Configuring for aria board...
gunzip.c: In function 'zunzip':
gunzip.c:101: warning: assignment from incompatible pointer type
In file included from zlib.c:29:
/home/wd/git/u-boot/work/include/u-boot/zlib.h:667: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'crc32'
zlib.c: In function 'inflate':
zlib.c:1388: warning: implicit declaration of function 'crc32'
make[1]: *** [/work/wd/tmp-ppc/lib_generic/zlib.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [/work/wd/tmp-ppc/lib_generic/libgeneric.a] Error 2
make: *** Waiting for unfinished jobs....
^Xppc_6xx-size: '/work/wd/tmp-ppc/u-boot': No such file


Please FIX this, and don't dare to resubmit it without thorough testing!

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"It's like deja vu all over again."                      - Yogi Berra


More information about the U-Boot mailing list