[U-Boot] [PATCH] ppc4xx: Fix EEPROM configuration on Kilauea
Wolfgang Denk
wd at denx.de
Wed Jul 22 11:42:49 CEST 2009
Dear Stefan Roese,
In message <200907220944.50403.sr at denx.de> you wrote:
> >
> > The commit message does not mention the increased write delay. Is htis
> > really needed? The (removed) comment says 5ms should be sufficient?
>
> 10ms is also used on many other AMCC eval boards. It's more defensive. But you
> are correct. I should have mentioned it in the commit message. I'll add it and
> resubmit.
Is there any reason for being so defensive here?
In any case I think you should add a comment, explaining your reasons.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I'm frequently appalled by the low regard you Earthmen have for life.
-- Spock, "The Galileo Seven", stardate 2822.3
More information about the U-Boot
mailing list