[U-Boot] [PATCH V5] ppc4xx: Add 405EP based PMC405DE board

Wolfgang Denk wd at denx.de
Wed Jul 22 11:49:48 CEST 2009


Dear Matthias Fuchs,

In message <200907221024.33607.matthias.fuchs at esd.eu> you wrote:
> On Wednesday 22 July 2009 09:26, Wolfgang Denk wrote:
> > Dear Matthias Fuchs,
> > 
> > In message <12481717431327-git-send-email-matthias.fuchs at esd.eu> you wrote:
> > > patch v2:
> > > 	- coding style cleanup
> > > 	- added CONFIG_PHY1_ADDR
> > > patch v3:
> > > 	- refactor PLL reconfiguration code
> > > 	- beautify some one-line-functions
> > > patch v4:
> > > 	- remove 'sbe' command
> > > 	- add CONFIG_CMD_CHIP_CONFIG support
> > > 	- use ppc4xx_gpio struct for GPIO access
> > > 	- use set/clrbits_be32 to modify GPIO registers
> > > 	- add CPLD register struct
> > > patch v5:
> > > 	- add patch history to commit message
> > 
> > Please get rid of this. This has NO place in the commit message. Such
> > comments go _below_ the "---" line.
> Do you want me to resend the posting?

Well, such a cmmit message is definitely not  acceptable,  so  please
consider this version rejected.

Please also note that there is still this indentation problem.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Nearly everyone is in favor of going  to  heaven  but  too  many  are
hoping  they'll  live  long  enough  to see an easing of the entrance
requirements. Never appeal to a man's "better nature." he  might  not
have one.


More information about the U-Boot mailing list