[U-Boot] [PATCH 2/2] P2020RDB Platform Support Added

Wolfgang Denk wd at denx.de
Wed Jul 22 12:47:24 CEST 2009


Dear "Aggrwal Poonam-B10812",

In message <1BD5CFC378ED0946B688E0C9BA2EF095129FFF at zin33exm24.fsl.freescale.net> you wrote:
> 
...
> > > +	val = pgpio->gpdat;
> > > +	temp = val & BOARDREV_MASK;
> > > +	if (temp == BOARDREV_C)
> > > +		board_rev = 'C';
> > > +	else if (temp == BOARDREV_B)
> > > +		board_rev = 'B';
> > 
> > What happens if it's neither BOARDREV_B nore BOARDREV_C ?
> It has to be rev b or revC , may be we can spin  here. 

Famous last words :-) Please at least print an error message.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The IQ of the group is the lowest IQ of a member of the group divided
by the number of people in the group.


More information about the U-Boot mailing list