[U-Boot] [PATCH 2/2] document network driver framework
Mike Frysinger
vapier at gentoo.org
Thu Jul 23 02:16:31 CEST 2009
On Wednesday 22 July 2009 19:00:40 Andy Fleming wrote:
> On Sat, Jul 18, 2009 at 8:04 PM, Mike Frysinger <vapier at gentoo.org> wrote:
> > +----------------
> > + CONFIG Options
> > +----------------
> > +
> > +The common config defines your device should respect (if applicable):
> > + CONFIG_MII - configure in MII mode
> > + CONFIG_RMII - configure in RMII mode
>
> That's awfully global, and inflexible. I don't think there's any
> convention here that should be encouraged. The data bus configuration is a
> per-device attribute. If some system architects choose to allow this into
> their config files, far be it from me to protest, but I'm against it.
feel free to fix it then. this is a case of me documenting existing practice
and not feeling like doing the footwork to fix drivers. you can not like it
all you want, but that doesnt change reality.
> Also, CONFIG_MII doesn't mean what you think it means. It stems from the
> obnoxious overlap in terms set forth by IEEE 802.3. The MII in this case
> refers to the MII Management bus. Defining CONFIG_MII will cause
> miiphyutil.c to be built, which is a bit-bang MII Management bus driver.
> It will also enable some MII Management features. CONFIG_MII is therefore
> a relevant CONFIG option for most drivers.
yes, that's obvious, so i'm not sure why i missed it (especially considering i
also wrote support for it in the Blackfin net driver). i'll update the doc.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090722/8996d90e/attachment.pgp
More information about the U-Boot
mailing list