[U-Boot] [PATCH 2/2] document network driver framework

Ben Warren biggerbadderben at gmail.com
Fri Jul 24 00:14:25 CEST 2009


Wolfgang Denk wrote:
> Dear Jean-Christophe PLAGNIOL-VILLARD,
>
> In message <20090723214946.GE9480 at game.jcrosoft.org> you wrote:
>   
>>> +And to control whether your driver is even enabled, you should use:
>>> +	CONFIG_SYS_NET_<DRIVERNAME>
>>>       
>> In my proposition CONFIG_SYS_ will be not use for driver enabling but for
>> hardware specific information
>>     
>
> Enabling or disabling a driver i ssomething that a dumb user can do,
> so it should be done using
>
> 	CONFIG_<DRIVERNAME>
>
> as in CONFIG_E1000, CONFIG_EEPRO100, etc.
>
>   
Fine with me, although I understand the argument that it doesn't convey 
enough information, especially when dealing with devices that are more 
obscure than Intel E1000.  CONFIG_SYS_APE is definitely wrong, I think 
CONFIG_NET_APE should be for networking features such as selectable 
protocols.  Maybe a compromise if one is needed would be 
CONFIG_NETDEV_APE ?  Or is it too verbose?

regards,
Ben


More information about the U-Boot mailing list