[U-Boot] [PATCH v3] Add support for Eukrea CPUAT91 SBC

[Jean-Christophe PLAGNIOL-VILLARD]

> --- a/MAKEALL
> +++ b/MAKEALL
> @@ -587,11 +587,12 @@ LIST_at91="			\
>  	at91sam9260ek		\
>  	at91sam9261ek		\
>  	at91sam9263ek		\
> -	at91sam9g10ek	\
> +	at91sam9g10ek		\
please do not touch non related part to your patch
please fix it in an other patch
>  	at91sam9g20ek		\
>  	at91sam9m10g45ek	\
>  	at91sam9rlek		\
>  	cmc_pu2			\
> +	cpuat91			\
>  	csb637			\
>  	kb9202			\
>  	meesc			\
> diff --git a/Makefile b/Makefile
> index 090e645..3b348d9 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2683,6 +2683,18 @@ at91rm9200ek_config	:	unconfig
>  cmc_pu2_config	:	unconfig
>  	@$(MKCONFIG) $(@:_config=) arm arm920t cmc_pu2 NULL at91rm9200
>  
> +cpuat91_ram_config \
> +cpuat91_config	:	unconfig
> +	@mkdir -p $(obj)include
> +	@if [ "$(findstring _ram_,$@)" ] ; then \
> +		echo "#define CONFIG_CPUAT91_RAM 1" >>$(obj)include/config.h ; \
same as other patch
no need please define the
#define CONFIG_SKIP_LOWLEVEL_INIT
#define CONFIG_SKIP_RELOCATE_UBOOT
here
> +		$(XECHO) "... CPUAT91 configured for RAM" ; \
> +	else \
> +		echo "#define CONFIG_BOOTDELAY 1" >>$(obj)include/config.h ;\
> +		$(XECHO) "... CPUAT91 configured for Flash" ;\
> +	fi;
> +	@$(MKCONFIG) -a cpuat91 arm arm920t cpuat91 eukrea at91rm9200
> +
>  csb637_config	:	unconfig
>  	@$(MKCONFIG) $(@:_config=) arm arm920t csb637 NULL at91rm9200
>  
> diff --git a/board/eukrea/cpuat91/Makefile b/board/eukrea/cpuat91/Makefile
> new file mode 100644
> index 0000000..08a90dc
> --- /dev/null
> +++ b/board/eukrea/cpuat91/Makefile
> @@ -0,0 +1,50 @@
> +#
> +# (C) Copyright 2003-2006
> +# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
> +#
> +# See file CREDITS for list of people who contributed to this
> +# project.
> +#
> +# This program is free software; you can redistribute it and/or
> +# modify it under the terms of the GNU General Public License as
> +# published by the Free Software Foundation; either version 2 of
> +# the License, or (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program; if not, write to the Free Software
> +# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> +# MA 02111-1307 USA
> +#
> +
> +include $(TOPDIR)/config.mk
> +
> +LIB	= $(obj)lib$(BOARD).a
> +
> +COBJS	:= cpuat91.o
please be consistant with your other patch
$(BOARD)
> +
> +SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
> +OBJS	:= $(addprefix $(obj),$(COBJS))
> +SOBJS	:= $(addprefix $(obj),$(SOBJS))
> +
> +$(LIB):	$(obj).depend $(OBJS) $(SOBJS)
> +	$(AR) $(ARFLAGS) $@ $(OBJS) $(SOBJS)
> +
> +clean:
> +	rm -f $(SOBJS) $(OBJS)
> +
> +distclean:	clean
> +	rm -f $(LIB) core *.bak .depend
> +
> +#########################################################################
> +
> +# defines $(obj).depend target
> +include $(SRCTREE)/rules.mk
> +
> +sinclude $(obj).depend
> +
<snip>
> +
> +#endif	/* CONFIG_CMD_NET */
> +#endif	/* CONFIG_DRIVER_ETHER */
> diff --git a/cpu/arm920t/at91rm9200/Makefile b/cpu/arm920t/at91rm9200/Makefile
> index 73aeeac..114d8ad 100644
> --- a/cpu/arm920t/at91rm9200/Makefile
> +++ b/cpu/arm920t/at91rm9200/Makefile
> @@ -31,14 +31,15 @@ COBJS	+= bcm5221.o
>  COBJS	+= dm9161.o
>  COBJS	+= ether.o
>  COBJS	+= i2c.o
> +COBJS-$(CONFIG_KS8721_PHY)	+= ks8721.o
>  COBJS	+= lxt972.o
>  COBJS	+= reset.o
>  COBJS	+= spi.o
>  COBJS	+= timer.o
>  COBJS	+= usb.o
>  
> -SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
> -OBJS	:= $(addprefix $(obj),$(SOBJS) $(COBJS))
> +SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c) $(COBJS-y:.o=.c)
> +OBJS	:= $(addprefix $(obj),$(SOBJS) $(COBJS) $(COBJS-y))
please switch all to COBJS-y
>  
>  all:	$(obj).depend $(LIB)
>  
you have also some whitespace in your patch please fix

Best Regards,
J.