[U-Boot] [PATCH v2] mpc83xx: Add esd VME8349 board support

[Kim Phillips]

On Fri, 24 Jul 2009 14:58:16 +0200
Stefan Roese <sr at denx.de> wrote:

> v2:
> - respect the original copyright holder(s)
> - typedefs in caddy.h removed
> - aduc.c removed
> - memset used
> - converted to use 83XX_GENERIC_PCI code
> - CONFIG_SYS_SICRH set to 0
> - hardcoded MAC and IP addresses removed

much better, Stefan, thanks, there's WD's comments plus a couple more
minor nits below:

> +	while (ctrlc() == 0) {
> +		if (caddy_interface->cmd_in != caddy_interface->cmd_out) {
> +			memset(result, 0, 5 * sizeof(result[0]));
> +			status = 0;
> +			caddy_cmd = &caddy_interface->cmd[caddy_interface->cmd_out];
> +			switch (caddy_cmd->cmd) {
> +			case CADDY_CMD_IO_READ_8:
> +				result[0] = in_8((void *)CONFIG_SYS_PCI1_IO_PHYS +
> +						 (caddy_cmd->addr & 0x001fffff));
> +				generate_answer(caddy_cmd, status, &result[0]);
> +				break;

lines too long.  WD's suggestions for fixing this up are in order.

> +	i2c_set_bus_num(1);
> +	/* Read the PCI_M66EN jumper setting */
> +	if ((i2c_read(CONFIG_SYS_I2C_8574_ADDR2, 0, 0, &reg8, sizeof(reg8)) == 0) ||
> +	    (i2c_read(0x38                     , 0, 0, &reg8, sizeof(reg8)) == 0)) {

lines too long.

> +#define CONFIG_PCI_SCAN_SHOW		/* show pci devices on startup */
> +#define CONFIG_SYS_PCI_SUBSYS_VENDORID 0x1057  /* Motorola */

should be Freescale's ID.

Thanks,

Kim