[U-Boot] [PATCH] zlib: allow 0 as destination pointer

Wolfgang Denk wd at denx.de
Mon Jul 27 20:15:51 CEST 2009


Dear rhabarber1848,

In message <h4kq2v$eoj$1 at ger.gmane.org> you wrote:
> 
> this patch solves the inflate() error but now a watchdog reset is triggered
> during decompression:
...
> The neither the old nor the new code incorporate WATCHDOG_RESET() so the new

You are wrong. The urrent code installs WATCHDOG_RESET as s.outcb()
callback; see function zunzip() in "lib_generic/gunzip.c".

> code seems to be slower than the old one which works. I have yet to dig
> through the zlib code to insert some WATCHDOG_RESET() here and there like I
> did with the LZMA code.

I think this is the wrong thing to do. Use the provided callback
instead.


I wonder why you do not create a patch between the old original
version and what wd have in U-Boot now (which should clearly show
what has been changed to adapt this code for U-Boot), and then apply
(if necessary, manually) that patch to the current version?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"You ain't experienced..." "Well, nor are you." "That's true. But the
point is ... the point is ... the point is we've been not experienced
for a lot longer than you. We've got  a  lot  of  experience  of  not
having any experience."           - Terry Pratchett, _Witches Abroad_


More information about the U-Boot mailing list