[U-Boot] [PATCH] Refresh LZMA-lib to v4.65
Wolfgang Denk
wd at denx.de
Mon Jul 27 22:49:09 CEST 2009
Dear Luigi Mantellini,
In message <b73e93990907271302g31b398d3qf4acf29d1af1351c at mail.gmail.com> you wrote:
> I have a stupid question: why the depend uses CPPFLAGS instead instead CFLAGS?
Because depend runs "$(CC) -M", i. e. just the preprocessor, so any
additional flags needed for later compiler passes don't matter anyway.
> can this patch be acceptable? Or there is something that I don't understand?
>
> diff --git a/rules.mk b/rules.mk
> index 6f999dd..998dd4e 100644
> --- a/rules.mk
> +++ b/rules.mk
> @@ -29,7 +29,7 @@ $(obj).depend: $(src)Makefile
> $(TOPDIR)/config.mk $(SRCS)
> @rm -f $@
> @for f in $(SRCS); do \
> g=`basename $$f | sed -e 's/\(.*\)\.\w/\1.o/'`; \
> - $(CC) -M $(HOSTCFLAGS) $(CPPFLAGS) -MQ
> $(obj)$$g $$f >> $@ ; \
> + $(CC) -M $(HOSTCFLAGS) $(CPPFLAGS) $(CFLAGS)
> -MQ $(obj)$$g $$f >> $@ ; \
> done
Looks wrong to me.
> On Mon, Jul 27, 2009 at 9:33 PM, Mike Frysinger<vapier at gentoo.org> wrote:
> > On Monday 27 July 2009 15:12:11 Luigi Mantellini wrote:
> >> On Mon, Jul 27, 2009 at 8:58 PM, Mike Frysinger<vapier at gentoo.org> wrote:
...
Arghhh. Mike already told you before: please do not top post / full
quote. Please read http://www.netmeister.org/news/learn2quote.html to
understand what this means.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A princess should not be afraid -- not with a brave knight to protect
her.
-- McCoy, "Shore Leave", stardate 3025.3
More information about the U-Boot
mailing list