[U-Boot] [PATCH/RFC] env: always build env_embedded and envcrc

Wolfgang Denk wd at denx.de
Mon Jul 27 22:52:52 CEST 2009


Dear Mike Frysinger,

In message <1248683475-2658-1-git-send-email-vapier at gentoo.org> you wrote:
> The envcrc utility is only called when it is actually needed, so having the
> internal code depend on ENV_IS_EMBEDDED isn't necessary.  Plus, by always
> building it, external utils can manipulate the environment blob without
> having to mess around with defines.

But always building some tool that is normally not needed just adds to
the compile time.

> Same logic holds for env_embedded.  It is already compiled for the majority
> of boards into a 0 byte file, so enabling it all the time shouldn't cause
> noticable change in overhead.  The difference now is that we link it into
> U-Boot itself only when CONFIG_ENV_IS_EMBEDDED is defined.

Again, I see added build time as a con for this patch - but I'm
failing to see any pro?

If you have "external utils" that might need this, please add a
separate Makefile target so you can build this separately, but save
all the rest of us the compile time overhead.

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
grep me no patterns and I'll tell you no lines.


More information about the U-Boot mailing list