[U-Boot] [PATCH] Fix FEC compile warning message

[Liew Tsi Chung-R5AAHP]

Wolfgang,

Yes, I will do that for the next merging window. Ignore this patch.

Thanks!

Best Regards,
TsiChung


-----Original Message-----
From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de]
On Behalf Of Wolfgang Denk
Sent: Tuesday, July 28, 2009 4:59 PM
To: TsiChung Liew
Cc: U-Boot; Ben Warre7n
Subject: Re: [U-Boot] [PATCH] Fix FEC compile warning message

Dear TsiChung Liew,

In message <1248799132-29720-1-git-send-email-tsicliew at gmail.com> you
wrote:
> Provide function protocol for icache_invalid().
> 
> Signed-off-by: TsiChung Liew <tsicliew at gmail.com>
> ---
>  drivers/net/mcffec.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/mcffec.c b/drivers/net/mcffec.c index 
> 64be5de..d3741a7 100644
> --- a/drivers/net/mcffec.c
> +++ b/drivers/net/mcffec.c
> @@ -95,6 +95,10 @@ struct fec_info_s fec_info[] = {  #endif  };
>  
> +#ifdef CONFIG_SYS_UNIFY_CACHE
> +extern void icache_invalid(void);
> +#endif

Could you please rename this function into invalidate_icache(), and add
a prototype declaration to include/asm-?/cache.h, like it is for example
doene for PowerPC in include/asm-ppc/cache.h ?

I would like to see that all architectures use the same names for the
same functions...

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de If
it has syntax, it isn't user friendly.
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot