[U-Boot] [PATCH] Make arm926ejs use -mabi=apcs-gnu to avoid EABI problems

[Wolfgang Denk]

Dear Prafulla & all,

in message <73173D32E9439E4ABB5151606C3E19E202EF7E99DC at SC-VEXCH1.marvell.com> you wrote:
> 
> > > > -PLATFORM_CPPFLAGS += -march=armv5te
> > > > +PLATFORM_CPPFLAGS += -march=armv5te -mabi=apcs-gnu
> > > 
> > > I could live with this part, if it was thoroughly tested and does not
> > > cause problems with the most frequently used tool chains (which I'm
> > > afraid it would - I think I remember that I saw errors or unexpected
> > > behaviour when using multiple, different "-mabi" settings).
> > 
> > It would be nice though if owners of other arm926ejs-boards could test
> > the patch and see that it doesn't break things. Depending on the
> > compiler, you might want to build with USE_PRIVATE_LIBGCC=yes.

Actually testing it is just one part of the issue, and actually the
less important one.

> Ack 
> But I think ack for other Arm architecture really important here :-)


I have to admit that I really hesitate ifwe should add this - the
longer I think about it, the more I tend to say no.

I understand that it's a quick workaround for the acute problem that
works with some tool chains and on some boards. This makes the "pro"
for this patch.

On the other hand, the fact remains that we  do  not  understand  the
exact  nature  of  the problem, as nobody has debugged it to the that
level yet. So even when we add this, we cannot be sure  if  it  fixes
all  problems,  on  all  systems, and with all tool chains - it might
happen as well that we run into the same issue again  soon,  or  that
there  are  still  issues  left somewhere, undetected. If we check in
this workaround, the motivation for digging for the real  cause  will
fade  away  quickly,  until  it hits us really hard. This makes a big
"con" for this patch.


I call upon everybody who has some time and resources and who is able
to reproduce the problem (so far I was not) to help and dig into this,
so we can understand what's going on, and finally fix the cause of the
problem, instead of trying to hush it up.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
All a hacker needs is a tight PUSHJ, a loose pair of UUOs, and a warm
place to shift.