[U-Boot] [PATCH] mem_mtest: fix error reporting, allow escape with ^C
Paul Gortmaker
paul.gortmaker at windriver.com
Fri Oct 2 02:04:27 CEST 2009
Mike Frysinger wrote:
> On Thursday 01 October 2009 19:52:27 Paul Gortmaker wrote:
>> if (iteration_limit && iterations > iteration_limit) {
>> - printf("Tested %d iteration(s) without errors.\n",
>> - iterations-1);
>> + printf("Tested %d iteration(s) with %lu errors.\n",
>> + iterations-1, errs);
>> return 0;
>
> if you're showing the errs variable, then presumably it could possibly be non-
> zero, so you wouldnt want to return 0 right ?
> return !!errs;
>
>> char *argv[]) incr = -incr;
>> }
>> #endif
>> - return rcode;
>> + return 0;
>
> i dont think you want to return 0 all the time here right ?
> return !!errs;
Doh! I had it in my mind to "return errs!=0;" and then forgot.
Thanks, I'll respin and resend tomorrow.
Paul.
>
> otherwise, the basic ^C handling is something that has annoyed me in the past,
> so acked-by for that :)
> -mike
More information about the U-Boot
mailing list