[U-Boot] [PATCH] ppc4xx: Fix msg "initialization as root-complex failed" upon PCIe scan
Stefan Roese
sr at denx.de
Fri Oct 2 14:50:19 CEST 2009
Hi Wolfgang,
On Friday 02 October 2009 14:41:58 Wolfgang Denk wrote:
> But looking at this patch, it seems that larger parts in this
> (supposedly) board-specific code are actually more or less identical.
>
> Should we not factor out such common code?
Yes, this could (should) be done. But there are differences in these board
specific functions. This consolidation could introduce new errors/bugs. And I
didn't want to do such a thing, now that the merge window is closed. And
frankly, I don't have the time for such a cleanup right now. But I'll put this
on my to-do list.
Cheers,
Stefan
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de
More information about the U-Boot
mailing list