[U-Boot] [PATCH] TI DaVinci DM646x: Adding initial support for DM6467 EVM

[Tom]

Paulraj, Sandeep wrote:
> 

<snip>

> 
>>> +
>>> +/* SoC Configuration */
>>> +#define CONFIG_ARM926EJS				/* arm926ejs CPU */
>>> +#define CONFIG_SYS_TIMERBASE		0x01c21400	/* use timer 0 */
>> Is there a logical register #define you could use instead of the magic
>> number?
> 
> I can include the hardware.h and get the value from there, but the way the hardware.h for DaVinci has evolved over the years, including it in the config will result in compilation failure.
> I'll add this to my TODO list and send in a patch to clean up for all DaVinci SOC's the moment I get some free cycles.
> 

That is fine.

>>> +
>>> +/* I2C Configuration */
>>> +#define CONFIG_HARD_I2C
>>> +#define CONFIG_DRIVER_DAVINCI_I2C
>>> +#define CONFIG_SYS_I2C_SPEED		80000
>> This speed is unusual.
> 
> The same speed has been used with a slightly older version of U-boot and has worked fine
> 
>> davinci_sonata.h has a comment that it had a silicon bug with 100k
>> Could the same comment be applied here ?
> 
> I don't believe so

Ok fine as-is.

Tom