[U-Boot] [PATCH 0/4] ppc4xx: Overhaul for cmd reginfo

Niklaus Giger niklaus.giger at member.fsf.org
Fri Oct 2 20:12:06 CEST 2009


The command "reginfo" got an overhaul for the ppc4xx. It dumps all the
relevant HW configuration registers (address, symbolic name, content).
This allows to easily detect errors in *.h files and changes in the HW
configuration.

It is split in the following parts:
- Cleanup some HW register names:
  Here you find all the changes in the include directory for new register names
  and adapting other ones to the names used by AMCC in their manuals, e.g.
  For 440EPx/GRPPC440EPx/GRX, Revision 1.15 – September 22, 2008
  For PPC405GP Embedded Processor, Revision 1.02 – March 22, 2006
- Apply new HW register names
  Modify all existing *.c files to use the new register names.
- Rework cmd reginfo
  Here the real work done to improve the reginfo command.
- respect 80-chars per line in ppc*.h files
  After running checkstyle.pl on the three previous patches I noted that in
  the *.h files there were a lot of long lines. This patch solves this problem.

I tested the changes on my PPC405GPr board HCU4 and PPC440EPx board HCU5.

Only ran MAKEALL 4xx as I have no other cross-compilers installed.

As I had not time to consult the documentation of all PPC440 variants (not have
I boards to test it) the code in reginfo will probably dump less registers for
none PPC440EPx variants.

The DMA-registers are not dumped for the PPC440.

I know that I could spend not only many hours but weeks to cleanup all the
PPC4xx register naming conventions.

I did not feel it my responsability to bring the lines in all 4xx board
specific code to fit into 80 chars. But I think I will have soon a look at
all the common 4xx files to bring them in shape as I would really like that
a tool like checkstyle.pl from the Linux kernel only reports my errors.
  
Niklaus Giger (4):
  ppc4xx: Cleanup some HW register names
  ppc_4xx: Apply new HW register names
  ppc4xx: Rework cmd reginfo
  ppc4xx: respect 80-chars per line in ppc*.h files

 board/amcc/bamboo/bamboo.c            |   32 +-
 board/amcc/canyonlands/canyonlands.c  |   22 +-
 board/amcc/ebony/ebony.c              |   22 +-
 board/amcc/katmai/katmai.c            |   22 +-
 board/amcc/luan/epld.h                |   22 +-
 board/amcc/luan/luan.c                |   22 +-
 board/amcc/ocotea/ocotea.c            |   22 +-
 board/amcc/sequoia/sequoia.c          |   28 +-
 board/amcc/taishan/showinfo.c         |  112 ++--
 board/amcc/taishan/taishan.c          |   22 +-
 board/amcc/yosemite/yosemite.c        |   32 +-
 board/amcc/yucca/yucca.c              |   22 +-
 board/esd/common/cmd_loadpci.c        |    2 +-
 board/esd/du440/du440.c               |   28 +-
 board/esd/pmc440/cmd_pmc440.c         |   10 +-
 board/esd/pmc440/pmc440.c             |   32 +-
 board/exbitgen/init.S                 |    4 +-
 board/gdsys/gdppc440etx/gdppc440etx.c |   32 +-
 board/gdsys/intip/intip.c             |   22 +-
 board/korat/korat.c                   |   28 +-
 board/lwmon5/lwmon5.c                 |   32 +-
 board/netstal/hcu5/hcu5.c             |   28 +-
 board/pcs440ep/pcs440ep.c             |   32 +-
 board/prodrive/alpr/alpr.c            |   52 +-
 board/prodrive/p3p440/p3p440.c        |   22 +-
 board/sandburst/common/ppc440gx_i2c.h |    2 +-
 board/sandburst/common/sb_common.c    |   22 +-
 board/xes/xpedite1000/xpedite1000.c   |   24 +-
 common/cmd_reginfo.c                  |  158 +----
 cpu/ppc4xx/4xx_pci.c                  |   48 +-
 cpu/ppc4xx/Makefile                   |    4 +
 cpu/ppc4xx/cpu_init.c                 |    4 +-
 cpu/ppc4xx/miiphy.c                   |   24 +-
 cpu/ppc4xx/reginfo.c                  |  369 +++++++++
 cpu/ppc4xx/speed.c                    |    6 +-
 drivers/net/4xx_enet.c                |  100 ++--
 include/4xx_i2c.h                     |    2 +-
 include/ppc405.h                      |  530 +++++++-------
 include/ppc440.h                      | 1401 +++++++++++++++++++--------------
 include/ppc4xx.h                      |   36 +-
 include/ppc4xx_enet.h                 |  314 ++++----
 post/cpu/ppc4xx/ether.c               |   50 +-
 42 files changed, 2108 insertions(+), 1690 deletions(-)
 create mode 100644 cpu/ppc4xx/reginfo.c



More information about the U-Boot mailing list