[U-Boot] [PATCH 1/4] ppc4xx: Cleanup some HW register names

[Niklaus Giger]

Hi Stefan

Am Sonntag 04 Oktober 2009 13:36:25 schrieb Stefan Roese:
> Hi Niklaus,
> 
> as mentioned in my review comment to patch 0/4, please put the patch
> description into this commit text as well.
Will come.
> On Friday 02 October 2009 20:12:08 Niklaus Giger wrote:
> > Signed-off-by: Niklaus Giger <niklaus.giger at member.fsf.org>
> > ---
> >  include/4xx_i2c.h     |    2 +-
> >  include/ppc405.h      |    4 +-
> >  include/ppc440.h      |  179 ++++++++++++++++++++++------------------
> >  include/ppc4xx_enet.h |  220
> >  +++++++++++++++++++++++++------------------------ 4 files changed, 216
> >  insertions(+), 189 deletions(-)
> >
> > diff --git a/include/4xx_i2c.h b/include/4xx_i2c.h
> > index f0e772c..070657f 100644
> > --- a/include/4xx_i2c.h
> > +++ b/include/4xx_i2c.h
> > @@ -63,7 +63,7 @@
> >  #define IIC_EXTSTS	(I2C_REGISTERS_BASE_ADDRESS+IICEXTSTS)
> >  #define IIC_LSADR	(I2C_REGISTERS_BASE_ADDRESS+IICLSADR)
> >  #define IIC_HSADR	(I2C_REGISTERS_BASE_ADDRESS+IICHSADR)
> > -#define IIC_CLKDIV	(I2C_REGISTERS_BASE_ADDRESS+IICCLKDIV)
> > +#define IIC_CLKDIV	(I2C_REGISTERS_BASE_ADDRESS+IIC0_CLKDIV)
> >  #define IIC_INTRMSK	(I2C_REGISTERS_BASE_ADDRESS+IICINTRMSK)
> >  #define IIC_XFRCNT	(I2C_REGISTERS_BASE_ADDRESS+IICXFRCNT)
> >  #define IIC_XTCNTLSS	(I2C_REGISTERS_BASE_ADDRESS+IICXTCNTLSS)
> > diff --git a/include/ppc405.h b/include/ppc405.h
> > index 5e56897..4c62249 100644
> > --- a/include/ppc405.h
> > +++ b/include/ppc405.h
> > @@ -578,7 +578,7 @@
> >  #define    IICEXTSTS	    0x09
> >  #define    IICLSADR	    0x0A
> >  #define    IICHSADR	    0x0B
> > -#define    IICCLKDIV	    0x0C
> > +#define    IIC0_CLKDIV	    0x0C
> >  #define    IICINTRMSK	    0x0D
> >  #define    IICXFRCNT	    0x0E
> >  #define    IICXTCNTLSS	    0x0F
> 
> Why did you "only" change one of there I2C defines? Not enough time to
>  change them all? Any chance that you could change the other defines as
>  well? Or remove them if they are not used at all.
Yes. No enough time and they would need cleaning up even more files.
Please let the patch without requiring to change these definitions too. I will 
try to devote some time to them later on.
> 
> Thanks.
> 
> Cheers,
> Stefan
> 
> --
> DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de
> 

Niklaus Giger