[U-Boot] [patch] dm355evm NAND support

[Paulraj, Sandeep]

> 
> David Brownell wrote:
> > This is the second half of my DM355 EVM support patches, adding
> > the NAND support now that the 4-bit ECC is merged:
> >
> >  - Kick in NAND support, enabling
> >      * the DaVinci NAND driver
> >      * its 4-bit ECC support
> >      * MTD_DEVICE (newish, should be automatic!)
> >      * 64-bit printf (newish, should be automatic!)
> >      * saving the environment in one NAND block
> >  - Configure for the 2GB SLC flash normally shipped with the EVM
> >      * move all sizing info to the end
> >      * LARGEPAGE option is gone
> >      * use first block for environment (it's otherwise unused)
> >      * ... if small page NAND is used, use 1 MByte bootloader area
> >  - Enable default 5 second bootdelay
> >
> > And a build fix:  set_bit()/clear_bit() param types changed.
> >
> > Supporting 2GB MLC chips would need (a) 256K blocks (b) bigger
> > malloc heap and (c) 4K pages ... with that last requiring NAND
> > core changes, to support 80 bytes of ECC data.
> >
> > Signed-off-by: David Brownell <dbrownell at users.sourceforge.net>
> > ---
> > DIFFERS FROM SANDEEP'S PATCH:  (a) 64-bit VSPRINTf, (b) no MLC hooks,
> > (c) environment in block 0, which would otherwise be wasted, (d) no
> > dependency on dubious "remove SZ_* symbols" patches, (e) buildfix
> >
> >  board/davinci/dm355evm/dm355evm.c  |    4 +--
> >  include/configs/davinci_dm355evm.h |   37 +++++++++++++++++++++--------
> ------
> >  2 files changed, 25 insertions(+), 16 deletions(-)
> >
> > --- a/board/davinci/dm355evm/dm355evm.c
> > +++ b/board/davinci/dm355evm/dm355evm.c
> > @@ -92,8 +92,8 @@ int board_eth_init(bd_t *bis)
> >  static void nand_dm355evm_select_chip(struct mtd_info *mtd, int chip)
> >  {
> >  	struct nand_chip	*this = mtd->priv;
> > -	u32			wbase = (u32) this->IO_ADDR_W;
> > -	u32			rbase = (u32) this->IO_ADDR_R;
> > +	unsigned long		wbase = (unsigned long) this->IO_ADDR_W;
> > +	unsigned long		rbase = (unsigned long) this->IO_ADDR_R;
> >
> 
> Nak.
> I have already ack-ed Sandeep's patch that contains this
> fix for the warning.  Please check with him.
That is correct, I did not add it to my tree because you ACK'ed this patch only after I sent a pull request. So obviously I cannot add a patch that has been ACK'ed to an already existing pull request.
This will be part of my next pull request which will have a similar fix for DM365 and hopefully the EMAC support for DM365 which should result in a fully functional DM365 EVM support.
> 
> In general it is better to break patches that do multiple things into
> multiple patches.  When you resubmit, please break this patch into its
> logical parts :
> 1. NAND
> 2. Environment
> 3. Bootdelay
> 
> Tom

If the u-boot-ti tree or the u-boot-arm tree is checked, all the above features which are being added are already in both trees.
When Tom sends a pull request to Wolfgang it should become part of Wolfgang's tree as well.

Afcourse it does not have the 64 bit VSPRINTf for which I was going to submit a patch anyway.

Thanks,
Sandeep