[U-Boot] [PATCH] arm926ejs: 16-byte align stack to avoid LDRD/STRD problems
Simon Kagstrom
simon.kagstrom at netinsight.net
Mon Oct 5 15:23:18 CEST 2009
U-boot for Marvell Kirkwood boards no longer work after the EABI changes
introduced in commit f772acf8a584067033eff1e231fcd1fb3a00d3d9. This
turns out to be caused by a stack alignment issue. The armv5te
instructions ldrd/strd instructions require 8-byte alignment to work
properly (otherwise undefined behavior), and start.S gave the stack a
12-byte alignment.
Tested on an OpenRD base board, where both printouts and ubifs stuff now
works.
Signed-off-by: Simon Kagstrom <simon.kagstrom at netinsight.net>
---
cpu/arm926ejs/start.S | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/cpu/arm926ejs/start.S b/cpu/arm926ejs/start.S
index 8043322..ca520eb 100644
--- a/cpu/arm926ejs/start.S
+++ b/cpu/arm926ejs/start.S
@@ -171,7 +171,8 @@ stack_setup:
#ifdef CONFIG_USE_IRQ
sub r0, r0, #(CONFIG_STACKSIZE_IRQ+CONFIG_STACKSIZE_FIQ)
#endif
- sub sp, r0, #12 /* leave 3 words for abort-stack */
+ sub sp, r0, #16 /* leave 3 words for abort-stack and */
+ /* align stack for ldrd/strd */
clear_bss:
ldr r0, _bss_start /* find start of bss segment */
--
1.6.0.4
More information about the U-Boot
mailing list