[U-Boot] [PATCH 2/3 v3] Add bb_miiphy_init call before any ethernet bring-up code.

Luigi Mantellini luigi.mantellini.ml at gmail.com
Mon Oct 5 22:04:31 CEST 2009


The lib_[arch]/board.c code calls the bb_miiphy_init that will do just 2 things:

1) Relocate the bb_mii_buses[i].* hooks (.init, .mdio_active, .delay, ...)
2) Call the board bb_mii_buses[i].init (board specific code).

The board specifc code will be contained into the hook .init filed
into the bb_mii_buses vector.

Do you have a better solution?

thanks and best regards,

luigi

On Mon, Oct 5, 2009 at 8:30 AM, Ben Warren <biggerbadderben at gmail.com> wrote:
> Hi Luigi,
>
> Luigi 'Comio' Mantellini wrote:
>>
>> From: Luigi 'Comio' Mantellini <luigi.mantellini at idf-hit.com>
>>
>> Signed-off-by: Luigi 'Comio' Mantellini <luigi.mantellini at idf-hit.com>
>> ---
>>  lib_arm/board.c      |    3 +++
>>  lib_avr32/board.c    |    3 +++
>>  lib_blackfin/board.c |    3 +++
>>  lib_i386/board.c     |    3 +++
>>  lib_m68k/board.c     |    3 +++
>>  lib_mips/board.c     |    3 +++
>>  lib_ppc/board.c      |    4 +++-
>>  lib_sh/board.c       |    3 +++
>>  lib_sparc/board.c    |    3 +++
>>  9 files changed, 27 insertions(+), 1 deletions(-)
>>
>
> I'm not sure about this.  Bit-banged MII is very board-specific, and IMHO
> should be initialized in board_eth_init()
>
> regards,
> Ben
>



-- 
Luigi 'Comio' Mantellini
R&D - Software
Industrie Dial Face S.p.A.
Via Canzo, 4
20068 Peschiera Borromeo (MI), Italy

Tel.: +39 02 5167 2813
Fax: +39 02 5167 2459
web: www.idf-hit.com
mail: luigi.mantellini at idf-hit.com


More information about the U-Boot mailing list