[U-Boot] [PATCH] mpc8xxx: improve LAW error messages when setting up DDR

Paul Gortmaker paul.gortmaker at windriver.com
Wed Oct 7 01:44:55 CEST 2009


When setting up the LAWs for the DDR, if there was an error,
you got the not-so-helpful error text "ERROR" and nothing
else.  Not only is it non-informative, but it is also
pretty frustrating trying to grep for "ERROR" in the source.

Signed-off-by: Paul Gortmaker <paul.gortmaker at windriver.com>
---
 cpu/mpc8xxx/ddr/util.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/cpu/mpc8xxx/ddr/util.c b/cpu/mpc8xxx/ddr/util.c
index 4451989..d0f61a8 100644
--- a/cpu/mpc8xxx/ddr/util.c
+++ b/cpu/mpc8xxx/ddr/util.c
@@ -89,16 +89,16 @@ __fsl_ddr_set_lawbar(const common_timing_params_t *memctl_common_params,
 			? LAW_TRGT_IF_DDR_INTRLV : LAW_TRGT_IF_DDR_1;
 
 		if (set_ddr_laws(base, size, lawbar1_target_id) < 0) {
-			printf("ERROR\n");
+			printf("set_lawbar: ERROR (%d)\n", memctl_interleaved);
 			return ;
 		}
 	} else if (ctrl_num == 1) {
 		if (set_ddr_laws(base, size, LAW_TRGT_IF_DDR_2) < 0) {
-			printf("ERROR\n");
+			printf("set_lawbar: ERROR (ctrl #2)\n");
 			return ;
 		}
 	} else {
-		printf("unexpected controller number %u in %s\n",
+		printf("set_lawbar: unexpected controller number %u in %s\n",
 			ctrl_num, __FUNCTION__);
 	}
 }
-- 
1.6.5.rc1



More information about the U-Boot mailing list