[U-Boot] [PATCH] relocation: Do not relocate NULL pointers.
Joakim Tjernlund
joakim.tjernlund at transmode.se
Thu Oct 8 10:56:32 CEST 2009
>
> Dear Joakim Tjernlund,
>
> In message <1254960231-11441-1-git-send-email-Joakim.Tjernlund at transmode.se> you wrote:
> > NULL is an absolute value and should not be relocated.
> > After this correction code like:
> > void weak_fun(void) __attribute__((weak));
> > printf("weak_fun:%p\n", weak_fun);
> > will still print null after relocation.
> >
> > Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund at transmode.se>
> > ---
> >
> > v2 - add ppc4xx
> > v3 - add 74xx_7xx
>
> Could you next time _please_ add this "v3" information to the
> Subject:, say as "[PATCH v3] relocation: ..." ?
You sure are hard to please :)
>
> Thanks!
>
>
> > cpu/74xx_7xx/start.S | 6 ++++--
> > cpu/mpc512x/start.S | 6 ++++--
> > cpu/mpc5xx/start.S | 6 ++++--
> > cpu/mpc5xxx/start.S | 6 ++++--
> > cpu/mpc8220/start.S | 6 ++++--
> > cpu/mpc824x/start.S | 6 ++++--
> > cpu/mpc8260/start.S | 6 ++++--
> > cpu/mpc83xx/start.S | 6 ++++--
> > cpu/mpc85xx/start.S | 6 ++++--
> > cpu/mpc86xx/start.S | 6 ++++--
> > cpu/mpc8xx/start.S | 6 ++++--
> > cpu/ppc4xx/start.S | 6 ++++--
> > 12 files changed, 48 insertions(+), 24 deletions(-)
>
> I really wonder why we have that many copis of that code :-(
>
>
> Applied to reloc branch.
>
>
> Jocke, Peter: am I understanding correctly that we now have everything
> in the "reloc" branch that we want to include with this upcoming
> release, i. e. that we can do the "final" testing now before I merge
> that branch into master?
Yes, I have nothing more ready and I believe everything is in place.
More information about the U-Boot
mailing list