[U-Boot] [PATCH] Cleanup: use constant

Wolfgang Denk wd at denx.de
Sun Oct 18 22:41:58 CEST 2009


Dear Niklaus Giger,

In message <1253686334-30500-1-git-send-email-niklaus.giger at netstal.com> you wrote:
> Signed-off-by: Niklaus Giger <niklaus.giger at netstal.com>
> ---
>  common/miiphyutil.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/common/miiphyutil.c b/common/miiphyutil.c
> index 66fd9ca..196ef4a 100644
> --- a/common/miiphyutil.c
> +++ b/common/miiphyutil.c
> @@ -299,7 +299,7 @@ int miiphy_reset (char *devname, unsigned char addr)
>  		debug ("PHY status read failed\n");
>  		return (-1);
>  	}
> -	if (miiphy_write (devname, addr, PHY_BMCR, reg | 0x8000) != 0) {
> +	if (miiphy_write (devname, addr, PHY_BMCR, reg | PHY_BMCR_RESET) != 0) {
>  		debug ("PHY reset failed\n");
>  		return (-1);
>  	}

Applied, thanks.

Ben, hope this is OK with you.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Faith may be defined briefly as an illogical belief in the  occurence
of the improbable.                                    - H. L. Mencken


More information about the U-Boot mailing list