[U-Boot] [PATCH 1/2 v4] env: only build env_embedded and envcrc when needed

Wolfgang Denk wd at denx.de
Sun Oct 18 23:32:15 CEST 2009


Dear Mike Frysinger,

In message <200910181701.33654.vapier at gentoo.org> you wrote:
>
> > Mike Frysinger wrote:
> > > The env code is protected by the ENV_IS_EMBEDDED define, so attempting to
> > > compile the code when this isn't defined is pointless.  Now that the env
> > > headers have unified around CONFIG_ENV_IS_EMBEDDED, convert the build
> > > system to only build the env objects when this is enabled.  And now that
> > > the env code is conditionally compiled, we can drop the source code
> > > checks.
> > >
> > > For people who want to extract the environment manually, add a new option
> > > CONFIG_BUILD_ENVCRC that only enables the envcrc utility.
> > >
> > > Signed-off-by: Mike Frysinger <vapier at gentoo.org>
> > > ---
> > > v4
> > > 	- rename config option to CONFIG_BUILD_ENVCRC
> > >
> > >  README                |    5 +++++
> > >  common/Makefile       |    3 ---
> > >  common/env_embedded.c |    7 -------
> > >  include/common.h      |    5 +++++
> > >  tools/Makefile        |    9 ++-------
> > >  tools/envcrc.c        |   11 +----------
> > >  6 files changed, 13 insertions(+), 27 deletions(-)
> > 
> > Applied, thanks.

Arghhh...

This patch seems to break a *lot* of boards:

...
Configuring for mgsuvd board...
ppc_6xx-ld: cannot find common/env_embedded.o
make: *** [/work/wd/tmp-ppc/u-boot] Error 1
ppc_6xx-size: '/work/wd/tmp-ppc/u-boot': No such file
Configuring for MHPC board...
ppc_6xx-ld: cannot find common/env_embedded.o
make: *** [/work/wd/tmp-ppc/u-boot] Error 1
ppc_6xx-size: '/work/wd/tmp-ppc/u-boot': No such file
Configuring for MPC86xADS board...
ppc_6xx-ld: cannot find common/env_embedded.o
make: *** [/work/wd/tmp-ppc/u-boot] Error 1
ppc_6xx-size: '/work/wd/tmp-ppc/u-boot': No such file
Configuring for MPC885ADS board...
ppc_6xx-ld: cannot find common/env_embedded.o
make: *** [/work/wd/tmp-ppc/u-boot] Error 1
ppc_6xx-size: '/work/wd/tmp-ppc/u-boot': No such file
Configuring for NETPHONE board...
ppc_6xx-ld: cannot find common/env_embedded.o
make: *** [/work/wd/tmp-ppc/u-boot] Error 1
ppc_6xx-size: '/work/wd/tmp-ppc/u-boot': No such file
Configuring for NETTA board...
ppc_6xx-ld: cannot find common/env_embedded.o
make: *** [/work/wd/tmp-ppc/u-boot] Error 1
ppc_6xx-size: '/work/wd/tmp-ppc/u-boot': No such file
Configuring for NETTA2 board...
ppc_6xx-ld: cannot find common/env_embedded.o
make: *** [/work/wd/tmp-ppc/u-boot] Error 1
ppc_6xx-size: '/work/wd/tmp-ppc/u-boot': No such file
Configuring for NETTA board...
ppc_6xx-ld: cannot find common/env_embedded.o
make: *** [/work/wd/tmp-ppc/u-boot] Error 1
ppc_6xx-size: '/work/wd/tmp-ppc/u-boot': No such file
... Version 1
Configuring for NETVIA board...
ppc_6xx-ld: cannot find common/env_embedded.o
make: *** [/work/wd/tmp-ppc/u-boot] Error 1
ppc_6xx-size: '/work/wd/tmp-ppc/u-boot': No such file
... Version 2
Configuring for NETVIA board...
ppc_6xx-ld: cannot find common/env_embedded.o
make: *** [/work/wd/tmp-ppc/u-boot] Error 1
ppc_6xx-size: '/work/wd/tmp-ppc/u-boot': No such file
Configuring for NX823 board...
ppc_6xx-ld: cannot find common/env_embedded.o
make: *** [/work/wd/tmp-ppc/u-boot] Error 1
ppc_6xx-size: '/work/wd/tmp-ppc/u-boot': No such file
Configuring for pcu_e board...
ppc_6xx-ld: cannot find common/env_embedded.o
make: *** [/work/wd/tmp-ppc/u-boot] Error 1
ppc_6xx-size: '/work/wd/tmp-ppc/u-boot': No such file
Configuring for QS823 board...
ppc_6xx-ld: cannot find common/env_embedded.o
make: *** [/work/wd/tmp-ppc/u-boot] Error 1
ppc_6xx-size: '/work/wd/tmp-ppc/u-boot': No such file
Configuring for QS850 board...
ppc_6xx-ld: cannot find common/env_embedded.o
make: *** [/work/wd/tmp-ppc/u-boot] Error 1
ppc_6xx-size: '/work/wd/tmp-ppc/u-boot': No such file
Configuring for QS860T board...
ppc_6xx-ld: cannot find common/env_embedded.o
make: *** [/work/wd/tmp-ppc/u-boot] Error 1
ppc_6xx-size: '/work/wd/tmp-ppc/u-boot': No such file
Configuring for quantum board...
ppc_6xx-ld: cannot find common/env_embedded.o
make: *** [/work/wd/tmp-ppc/u-boot] Error 1
ppc_6xx-size: '/work/wd/tmp-ppc/u-boot': No such file
Configuring for R360MPI board...
ppc_6xx-ld: cannot find common/env_embedded.o
make: *** [/work/wd/tmp-ppc/u-boot] Error 1
ppc_6xx-size: '/work/wd/tmp-ppc/u-boot': No such file
...

etc. etc.

Please fix, or should I rather revert the commit?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The faster I go, the behinder I get.                 -- Lewis Carroll


More information about the U-Boot mailing list