[U-Boot] [PATCH 2/3] video: mb862xx: add option VIDEO_FB_16BPP_WORD_SWAP for IPEK01

[Wolfgang Denk]

Dear Wolfgang Grandegger,

In message <4ADC56E4.40907 at grandegger.com> you wrote:
>
> >> In 16 bpp mode, the new IPEK01 board only requires swapping of D16 words
> >> for D32 accesses due to the diffferent connecting to the GDC bus. This
> >> patch introduces the configuration option VIDEO_FB_16BPP_WORD_SWAP,
> >> which should be set for all board using the mb862xx in 16 bpp mode. For
> >> the IPEK01, VIDEO_FB_16BPP_PIXEL_SWAP should not be set.
> > 
> > I don't see any functional change in this patch - all you do is
> > renaming VIDEO_FB_16BPP_PIXEL_SWAP into VIDEO_FB_16BPP_WORD_SWAP.
> > 
> > This makes no sense to me.
> 
> Please have a look to the patched file. VIDEO_FB_16BPP_PIXEL_SWAP is
> used in other locations as well. This type of swapping is related to the
> way the GDC on the Socrates and lwmo5 board is connected.

I see.

But please add a description of VIDEO_FB_16BPP_PIXEL_SWAP and
VIDEO_FB_16BPP_WORD_SWAP to the README.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
       There is enough for the need of everyone in this world,
       but not for the greed of everyone.     - Mahatma Gandhi