[U-Boot] [u-boot] [PATCH] [2/2] [v1.2] mxc_fec: avoid free() calls to already freed pointers.

javier Martin javier.martin at vista-silicon.com
Tue Oct 20 16:44:13 CEST 2009


>
>>  /**
>> + * @brief Possible values for status
>> + *
>> + * fec_halt() changes the status to FEC_HALT_STATUS and fec_init()
>> + * changes the status to FEC_INIT_STATUS
>> + */
>> +#define FEC_HALT_STATUS 0
>> +#define FEC_INIT_STATUS 1
>
> It would seem more logical to me if you swapped names around, i. e.
> please use FEC_STATUS_INIT and FEC_STATUS_HALT.
>
> Also, we might consider using an enum here?


No problem, let me fix it and resend.

Thank you for the comments.

-- 
Javier Martin
Vista Silicon S.L.
CDTUC - FASE C - Oficina S-345
Avda de los Castros s/n
39005- Santander. Cantabria. Spain
+34 942 25 32 60
www.vista-silicon.com


More information about the U-Boot mailing list