[U-Boot] [PATCH 1/5] Check for NULL prompt in readline_into_buffer()

[Peter Tyser]

Wolfgang Denk wrote:
> Dear Peter Tyser,
> 
> In message <1256259563-32725-1-git-send-email-ptyser at xes-inc.com> you wrote:
>> Previously, passing readline() or readline_into_buffer() a NULL 'prompt'
>> parameter would result in puts() printing garbage when
>> CONFIG_CMDLINE_EDITING was enabled.
> 
> What would be the situation when this happens? I cannot see easily how
> to trigger this bug?

I don't think anything in current code would trigger this.  If some 
boards enabled CONFIG_CMDLINE_EDITING, they would have issues, eg 
board/eltec/bab7xx/misc.c.

So its not fixing a bug, just preventing a future one:)  It was also 
necessary to implement the 5/5 patch "Add 'editenv' command" which is 
how I triggered the "future bug".

In this series, patches 1/2/4 are non-critical cleanup/fixes.  I didn't 
plan on them get merged for the upcoming release, but I think they 
should get picked up at some point.  Patches 3/5 add new features - 
basically support for a new 'editenv' command.  These changes are more 
debatable, so we can discuss if you'd like to include these or not.

Best,
Peter