[U-Boot] [PATCH v2] davinci timer.c: Remove volatiles and memory mapped structures

[Paulraj, Sandeep]

> 
> Paulraj, Sandeep wrote:
> >
> >> Remove volatiles and memory mapped structure accesses and replace with
> >> readl and writel macro usage.
> >>
> >> Signed-off-by: Nick Thompson <nick.thompson at gefanuc.com>
> >> ---
> >> This patch was originally part of the da830 support patch, but this
> >> effort is now being integrated into davinci. As a result, these
> >> changes would be have been lost, as no change is required for da830.
> >> The changes where request to be kept available however, so here they
> >> are.
> >>
> >>  cpu/arm926ejs/davinci/timer.c |   29 +++++++++++++++++------------
> >>  1 files changed, 17 insertions(+), 12 deletions(-)
> >
> > I started the process of integrating into my branch and doing some quick
> tests on other DM parts.
> > But, I got 2 checkpatch warnings while running checkpatch.
> > One of them I believe is unavoidable because U-boot does not have a
> linux/io.h
> >
> > The other deals with using a typedef.
> 
> I only get one warning with 0.09 of checkpatch. It warns about not adding
> new typedefs.
> The typedef is already there though - I only removed the volatile. No
> excuse really.
I know and I understand this is precisely what gets on the nerves of everybody who submits updates to existing pieces of code. They end up cleaning stuff which they did not introduce.
> 
> In this case I expect it is fine to just to use a struct instead. Do you
> want me
> to make that change?
It's a simple change. Yes please make the change and then I can get on with the process of applying the patch.

Thanks,
Sandeep