[U-Boot] Fw: Re: Re: [PATCH] add u-boot sja1000/can support

Wolfgang Denk wd at denx.de
Mon Oct 26 23:00:56 CET 2009


Dear "=?utf-8?B?bWlhb2ZuZw==?=",

In message <200910261647227347739 at gmail.com> you wrote:
> Hi mike,
> It seems there's a big difference between my current project
> and u-boot common usage. I can only enjoy the patch myself now
> 
> i want to get a packet from usb/network, then redirect it to can bus.
> So blocked write/read of can is not allowed.
> 
> On Monday 26 October 2009 00:48:39 miaofng wrote:
> > Thanks for careful review. I'll resend the patch according to your remarks
> >  except follwing: 1)
> > 
> > > +int register_candev(struct can_device *dev)
> > 
> > use "can" or "candev", dont mix the two
> > 
> > answer: register_candev is origin from register_netdev(...). CAN is
> >  something like network, it may has high level protocols such as open-can
> >  and etc, so i want to keep that story.
> i know what CAN is.  the Linux approach makes sense because they've 
> architected CAN at the socket() layer, and all of the network layers are 
> written with common coding style.  but there is no such socket/network layer 

Arghhhh...

Your quoting is as broken as your (missing or incorrect) In-reply-to:
and References:  file headers. Please make sure to read
http://www.netmeister.org/news/learn2quote.html, and make sure not to
corrupt mail threads.

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You can't have everything... where would you put it?  - Steven Wright


More information about the U-Boot mailing list