[U-Boot] [PATCH] ARM AT91 new board EB+CPUx9K2

Jens Scharsig esw at bus-elektronik.de
Tue Oct 27 13:38:29 CET 2009


Wolfgang Denk schrieb:
> Dear Jens Scharsig,
>> +int board_init(void)
>> +{
>> +	/* Enable Ctrlc */
>> +	console_init_f();
>> +
>> +	/* Correct IRDA resistor problem / Set PA23_TXD in Output */
>> +	((AT91PS_PIO) AT91C_BASE_PIOA)->PIO_OER = AT91C_PA23_TXD2;
> 
> Please use I/O accessors to access device registers. Please fix
> globally.
Do you mean change to

writel(AT91C_PA23_TXD2, ((AT91PS_PIO) AT91C_BASE_PIOA)->PIO_OER);

like notation


Best regards Jens



More information about the U-Boot mailing list