[U-Boot] [PATCH 1/5 v2] Check for NULL prompt in readline_into_buffer()
Wolfgang Denk
wd at denx.de
Tue Oct 27 21:01:03 CET 2009
Dear Peter Tyser,
In message <1256501576-19700-1-git-send-email-ptyser at xes-inc.com> you wrote:
> Previously, passing readline() or readline_into_buffer() a NULL 'prompt'
> parameter would result in puts() printing garbage when
> CONFIG_CMDLINE_EDITING was enabled.
>
> Note that no board currently triggers this bug. Enabling
> CONFIG_CMDLINE_EDITING on some boards (eg bab7xx) would result in
> the bug appearing. This change is only intended to prevent someone
> from running into this issue in the future.
>
> Signed-off-by: Peter Tyser <ptyser at xes-inc.com>
> ---
> Changes since v1:
> - Updated commit message
>
> This change isn't strictly necessary for the new "editenv" command, I just
> noticed it during development of the "editenv" command.
Regarding the whole series: some of the patches fix actual bugs
(including potential ones), i. e. 1/5 and 4/5, or cleanups (2/5),
which I want to have in the next release. The other ones are new
stuff, which should actually go into "next", but then I don't want to
rip the patch sequence apart.
And we don't have -rc1 yet, so I allow myself to apply the whole
series now.
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
In any group of employed individuals the only naturally early riser
is _always_ the office manager, who will _always_ leave reproachful
little notes ... on the desks of their subordinates.
- Terry Pratchett, _Lords and Ladies_
More information about the U-Boot
mailing list