[U-Boot] [PATCH v3 1/2] NET: Move MDIO regs out of TSEC Space

[Kumar Gopalpet-B05799]

>-----Original Message-----
>From: Kumar Gala [mailto:galak at kernel.crashing.org] 
>Sent: Wednesday, October 28, 2009 8:27 PM
>To: Kumar Gopalpet-B05799
>Cc: Phillips Kim-R1AAHA; u-boot at lists.denx.de
>Subject: Re: [U-Boot] [PATCH v3 1/2] NET: Move MDIO regs out 
>of TSEC Space
>
>
>On Oct 28, 2009, at 3:49 AM, Sandeep Gopalpet wrote:
>
>> Moved the mdio regs out of the tsec structure,and provided different 
>> offsets for tsec base and mdio base so that provision for 
>etsec2.0 can 
>> be provided.
>>
>> This patch helps in providing the support for etsec2.0 In etsec2.0, 
>> the MDIO register space and the etsec reg space are different.
>>
>> Also, moved the TSEC_BASE_ADDR and MDIO_BASE_ADDR definitons into 
>> platform specific files.
>>
>> Signed-off-by: Sandeep Gopalpet <sandeep.kumar at freescale.com>
>> ---
>> drivers/net/tsec.c           |   19 ++++++++---------
>> include/asm-ppc/immap_83xx.h |    9 ++++++++
>> include/asm-ppc/immap_85xx.h |   10 +++++++++
>> include/asm-ppc/immap_86xx.h |    9 ++++++++
>> include/tsec.h               |   45 +++++++++++++++++++ 
>> +---------------------
>> 5 files changed, 59 insertions(+), 33 deletions(-)
>>
>>
>[snip]
>
>> diff --git a/include/asm-ppc/immap_83xx.h b/include/asm-ppc/ 
>> immap_83xx.h index c60a7d2..57b1a72 100644
>> --- a/include/asm-ppc/immap_83xx.h
>> +++ b/include/asm-ppc/immap_83xx.h
>> @@ -868,4 +868,13 @@ typedef struct immap { #endif #define 
>> CONFIG_SYS_MPC83xx_USB_ADDR \
>> 			(CONFIG_SYS_IMMR + 
>CONFIG_SYS_MPC83xx_USB_OFFSET)
>> +
>> +#define CONFIG_SYS_TSEC1_OFFSET		0x24000
>> +#define TSEC_SIZE			0x01000
>
>Let's leave TSEC_SIZE in tsec.h as its never changing
>
>> +
>> +#define CONFIG_SYS_MDIO1_OFFSET		0x24520
>> +#define MDIO_OFFSET			0x01000
>
>didn't we agree to rename to TSEC_MDIO_OFFSET
>
>> +
>> +#define TSEC_BASE_ADDR		(CONFIG_SYS_IMMR + 
>CONFIG_SYS_TSEC1_OFFSET)
>> +#define MDIO_BASE_ADDR		(CONFIG_SYS_IMMR + 
>CONFIG_SYS_MDIO1_OFFSET)
>

OK. Will change them. I apolozise for not incorporating them in my last
patch.


-Thanks
Sandeep